Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use chain not supported component rfox unstake and change address #7600

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

NeOMakinG
Copy link
Collaborator

Description

We would like to make it clearer for our user than they can't use the unstake, change address components if they are using a wallet not supporting Arbitrum

To achieve this, I exported the <ChainNotSupported /> component to the Shared folder and reused it in each rFOX features

Issue (if applicable)

Follow up of #7569

Risk

Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Use an account without the Arbitrum chain
  • Go to rFOX
  • Try to click on Claim, unstake and change address, you should see the Chain not supported component

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

image
image

@NeOMakinG NeOMakinG requested a review from a team as a code owner August 22, 2024 07:54
@0xApotheosis 0xApotheosis self-assigned this Aug 25, 2024
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the box!

The <ChainNotSupported /> does not show when an Arbitrum account is connected, and...

Unstake without Arbitrum account:

Screenshot 2024-08-26 at 9 04 22 AM

Claim without Arbitrum account:

Screenshot 2024-08-26 at 9 04 38 AM

Change address without arbitrum account:

Screenshot 2024-08-26 at 9 04 53 AM

Noting that the <ChainNotSupported /> is not shown from the stake tab when we do not have an Arbitrum account connected, though from the diff it appears this is expected:

Screenshot 2024-08-26 at 9 05 11 AM

@0xApotheosis 0xApotheosis merged commit 66952c1 into develop Aug 25, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the ledger-ack-rfox-improve branch August 25, 2024 23:07
gomesalexandre pushed a commit that referenced this pull request Aug 27, 2024
#7600)

Co-authored-by: Apotheosis <0xapotheosis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants