fix: fee explainer modal close button #7611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeOMakinG
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Close but this is not the reason why it had a deadclick and it's not 100% fixed because half of the closing button is clickable
The main reason why it's a dead click is that the tab container is over the closing button
Using a ModalBody almost fixes it because the body adds some paddings preventing the tablist to be over the close button
I would keep the body but remove the padding so its semantic is following chakra's idea and add a small zIndex on the closing button
NeOMakinG
reviewed
Aug 23, 2024
NeOMakinG
reviewed
Aug 23, 2024
|
That works, @NeOMakinG! Addressed in 42e5057 The z-index does the trick of ensuring it stays clickable. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the dead click on the fee explainer close modal, likely caused by the Chakra package bump due to our incorrect usage (or lack thereof) of `.
Issue (if applicable)
Closes #7610
Risk
Low
None
Testing
Ensure that the fee explainer can be closed using the close button (not just clicking the background).
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
See above.