Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh rfox information after unstaking and claiming #7613

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

NeOMakinG
Copy link
Collaborator

Description

Where you are unstaking from rFOX and claiming, the overview balances and over informations were not refreshed

This is due to a wrong address to build the queryKey that we still invalidate

Issue (if applicable)

closes #7559

Risk

Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Try to unstake, the balance on the overview should be refreshed when the TX get confirmed
  • Try to claim, claim rows should be updated right after (see the jam)

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

https://jam.dev/c/9aa34541-2883-460c-8d54-c3f81d1d965e

@NeOMakinG NeOMakinG requested a review from a team as a code owner August 23, 2024 13:51
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against prod and was able to repro there, though only for "Unstake" - stake is seemingly happy, and so is "Claim"

Also tested on develop and could also repro for unstake.

Tested in this diff:

  • Stake is still happy (paranoia check, untouched in this diff)

https://jam.dev/c/6eab0f25-da9b-4cab-8305-7840bb860b81

  • Unstake is happy

https://jam.dev/c/22fad99f-f1f4-4ebd-bee3-3d5f23cb848c

  • Claim is happy

https://jam.dev/c/22fad99f-f1f4-4ebd-bee3-3d5f23cb848c

  • Claim is happy

https://jam.dev/c/42f140d3-9011-4e77-a19d-bc22e67b0d6f

@gomesalexandre gomesalexandre enabled auto-merge (squash) August 23, 2024 16:39
@gomesalexandre gomesalexandre merged commit 4cc0e89 into develop Aug 23, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the rfox-unstake-refresh branch August 23, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rfox balances are not updated after unstaking and staking
2 participants