-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: market-data slice improvements #7615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
commented
Aug 23, 2024
NeOMakinG
reviewed
Aug 27, 2024
NeOMakinG
reviewed
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
NeOMakinG
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://jam.dev/c/1b765ee4-5c79-44e1-9107-c64dd3ffb685
Couldn't find any regression, nice job!
gomesalexandre
force-pushed
the
fix_fiat_ramps_perf_2
branch
3 times, most recently
from
August 27, 2024 09:30
64a401c
to
3fc4c2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
findByAssetIds
andfindPriceHistoryByAssetIds
endpoints in profit offindByAssetId
andfindPriceHistoryByAssetId
.This ensures:
The reason is RTK query args are shallow compared, and having the same AssetId in different
assetIds[]
args between runs means market-data will be refetched. By fetching one vs. many, we avoid this and ensure caching works as it should.Issue (if applicable)
N/A, though relates to the closed #7599
Risk
Low, but effectively medium given the surface area. See testing steps.
Testing
Ensure market-data is happy across the app:
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/464026f7-308e-4061-b94a-b1cd54a609f3