feat: thorchain lp ledger open app ack

[gomesalexandre]

Description

Does precisely what you'd expect it to do based on its box content, minus deposit/withdraw execution bits (implemented in useSendThorTx as part of #7628)

Issue (if applicable)

closes #7580

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

• THORChain LP approval displays the Ledger Open App ack
• THORChain LP deposit displays the Ledger Open App ack
• THORChain LP withdraw displays the Ledger Open App ack

Engineering

• ^

Operations

• 🏁 My feature is behind a flag and doesn't require operations testing (yet)

• ^

Screenshots (if applicable)

• Approve

• Add Liquidity

• Remove Liquidity

[kaladinlight]

Looks like we are missing this check in Sweep which is a possible flow in Thorchain LP. Also noticing we simply haven't added this check around standard sends useFormSend as a side note

[gomesalexandre]

Looks like we are missing this check in Sweep which is a possible flow in Thorchain LP. Also noticing we simply haven't added this check around standard sends useFormSend as a side note

Actually very valid side note, added it in handleSend will both handle sweeps and regular sends - 39154e5:

• Add Liquidity Sweep

• THORChain Savers Deposit Sweep

Note sends from the send modal are currently borked in this diff - to be tackled in a follow-up as well as we can't open a modal within a modal and we'll need to update the Modal provider to accomodate that.

Note the double checks in useSendThorTx's executeTransaction, which are expected for the time being (the first because of the current accountNumber shenanigans, fixed in #7635 above, the second being the actual one we want).
Going to follow-up with a holistic change at adapters-level so adapter methods that rely on on-device derivation take checkLedgerAppOpenIfLedgerConnected in instead, so this logic is better encapsulated and most importantly, so we are required to pass it.

[kaladinlight]

Note the double checks in useSendThorTx's executeTransaction, which are expected for the time being (the first because of the current accountNumber shenanigans, fixed in #7635 above, the second being the actual one we want). Going to follow-up with a holistic change at adapters-level so adapter methods that rely on on-device derivation take checkLedgerAppOpenIfLedgerConnected in instead, so this logic is better encapsulated and most importantly, so we are required to pass it.

On the same page with the holistic update. Current setup not super manageable and prone to regressions or forgetting on new implementations. Handling at adapter level makes a lot of sense. Wondering if we could leverage event emitters and have it completely encapsulated in chain adapters to reduce the need to propagate the function pass through everywhere. Then we can just listen for the ledger app open event and show the modal accordingly.

[kaladinlight]

approving - noting send modal will be tackled as a follow up. also, holy log spew for this hook, going to add a quick follow up to silence that as well