Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show cosmos pending undelegation #7636

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

kaladinlight
Copy link
Contributor

Description

Fix filtering of undelegations to ensure utc seconds are compared against utc seconds.

Issue (if applicable)

closes #7608

Risk

High Risk PRs Require 2 approvals

Low

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Make sure you have a pending undelegation and ensure it is shown in the cosmos staking position overview

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

☝️

Screenshots (if applicable)

image

@kaladinlight kaladinlight requested a review from a team as a code owner August 27, 2024 18:36
@NeOMakinG NeOMakinG self-requested a review August 28, 2024 07:57
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before

image

After

image

I confirm

      opportunityData.undelegations.some(undelegation => {
        return dayjs().isBefore(dayjs(undelegation.completionTime).unix())
      })

was evaluating to false

@kaladinlight kaladinlight enabled auto-merge (squash) August 28, 2024 16:02
@kaladinlight kaladinlight merged commit 55633e4 into develop Aug 28, 2024
3 checks passed
@kaladinlight kaladinlight deleted the fix-pending-undelegation branch August 28, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pending cosmos undelegations not showing up in UI
2 participants