feat: bitcoinjs-lib remove MAX_SAFE_INTEGER limitations #8130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeOMakinG
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Sending 1 DOGE is correctly spread on the network waiting for confirmation: https://jam.dev/c/470dc8bf-3edd-4be6-81f6-ce9cad657e3b
Seems fine to me
|
This is the wrong bitcoinjs-lib. We need to patch the shapeshift fork currently being used in hdwallet |
kaladinlight
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
i.e those limitations are perfectly fine for Bitcoin as we will never overflow them, but for e.g DOGE, it's pretty easy to end up in situation with outputs for which the value
is greater than MAX_SAFE_INTEGER (but lower than MAX_VALUE).
This removes the check to unbork things for that user.
Issue (if applicable)
closes #8128
Risk
Very high - for those high-value Txs, things could overflow. If any output Tx is malformed, this could end up in either receiving less than attempted, getting less change than expected, or a mix of both, with the network being gifted the overflown mistake.
Testing
Engineering
Operations
Screenshots (if applicable)