Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-enable PUBLIC_TRADE_ROUTE flag #8159

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

gomesalexandre
Copy link
Contributor

Description

Actually keeping the flag as off in prodish envs for now so swapper boots back to splash page without a wallet connected, 3 visual issues have been found out by ops in https://discord.com/channels/554694662431178782/1308774923317022752/1308934924341870628, to be specced out.

The focus of the quotes vs. rates PR was on, well, quotes vs. rates, and not enough love has been given to the actual no wallet connected flow just yet so this will be for a follow-up PR!

Issue (if applicable)

N/A

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low - there is only one consumption of this flag and that is for booting back to the splash page in trade route.

Testing

Engineering

  • Run yarn env app
  • Ensure you get booted back to splash screen without a wallet connected in trade route

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • Ensure you get booted back to splash screen without a wallet connected in trade route

Screenshots (if applicable)

https://jam.dev/c/5fee9b56-5437-444d-9c14-9dd4ebb05511

@gomesalexandre gomesalexandre requested a review from a team as a code owner November 21, 2024 04:14
.env.app Outdated Show resolved Hide resolved
@gomesalexandre gomesalexandre merged commit d2f770c into release Nov 21, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the feat_splash_screen_boot branch November 21, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants