-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: thorchain utxo unknown fees #8189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
commented
Nov 25, 2024
gomesalexandre
commented
Nov 25, 2024
packages/swapper/src/swappers/ThorchainSwapper/utils/getL1Rate.ts
Outdated
Show resolved
Hide resolved
gomesalexandre
commented
Nov 25, 2024
src/components/MultiHopTrade/hooks/useGetTradeQuotes/getTradeQuoteInput.ts
Outdated
Show resolved
Hide resolved
gomesalexandre
changed the title
feat: thorchain utxo unknown fees
fix: thorchain utxo unknown fees
Nov 25, 2024
0xApotheosis
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Gas fee shows for UTXOs when wallet is connected
✅ Gas fee still unknown for UTXOs without wallet connected
✅ Connecting a wallet after getting a UTXO quote correctly fetches the gas fees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures we get fees estimation back at input time for UTXOs, by leveraging xpub when available. This is after #8079 went in, which made UTXO fees unknown for UTXOs regardless of wallet connected state, and only got the fees on final quote getting before sign and broadcast.
While this was a feature, ops rightly pointed out that it effectively looks and feels like a regression, and if it does so, it probably is.
Fixed by leveraging xpub if handy (i.e if wallet connected) to actually estimate things.
Issue (if applicable)
closes #
Risk
Testing
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/873fc60a-82fe-429f-a274-b99f05553e65