feat: new wallet flow keepkey support #8630
Open
+206
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
changed the title
0xApotheosis
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does precisely what it says on the box - brings KK in to the new wallet flow.
Issue (if applicable)
closes #8592
Risk
Medium. Doesn't touch current code paths, but this is eventually making its way to prod, so treat it as that.
Testing
Engineering
REACT_APP_FEATURE_NEW_WALLET_FLOWflag on, KK is happyREACT_APP_FEATURE_NEW_WALLET_FLOWflag off, KK is (still) happyOperations
REACT_APP_FEATURE_NEW_WALLET_FLOWflag off (i.e what you're testing in this release), paranoia regression test that KK is (still) happyScreenshots (if applicable)
Flag on
https://jam.dev/c/ef22c1fe-d560-4b9e-9735-dccef9f80a5a
Flag off
https://jam.dev/c/ede50a06-44e0-4c35-b192-cad8ae36c7f9