Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYS-192 add github ci #8

Merged
merged 38 commits into from
Jul 31, 2024
Merged

SYS-192 add github ci #8

merged 38 commits into from
Jul 31, 2024

Conversation

TieDyedSheep
Copy link
Contributor

@TieDyedSheep TieDyedSheep commented Jul 8, 2024

DO NOT MERGE without approval from Andrew!

@TieDyedSheep TieDyedSheep requested a review from a team July 8, 2024 19:29
Copy link

linear bot commented Jul 8, 2024

SYS-192 monitor-client github workflow

https://github.com/shardeum/x-monitor-client

  • Create a PR with this workflow script .github/workflows/ci.yml
  • adjust the npm scripts in package.json needed. The might be missing. In the case of npm test if it if has the default echo and error make sure it doesn't fail
    • scripts used in shared workflow:
      • npm run lint
      • npm run format-check
      • npm run build
      • npm test

.github/workflows/ci.yml

name: Node CI Workflow
# The parameters are defaulted at the org level but can be overridden on the repository.
on:
  push:
    branches:
      - dev
      - main
  pull_request:
    branches:
      - dev
      - main
  workflow_dispatch:
    inputs:
      workflowBranch:
        description: 'Branch of the reusable workflow. Defaults to main, select dev for testing only.'
        required: true
        default: 'main'
        type: choice
        options:
          - dev
          - main
jobs:
  ci-dev:
    if: ${{ github.event.inputs.workflowBranch == 'dev' }}
    uses: shardeum/github-automation/.github/workflows/node-ci-shared.ymldev

  ci-main:
    if: ${{ github.event.inputs.workflowBranch == 'main' || !github.event.inputs.workflowBranch }}
    uses: shardeum/github-automation/.github/workflows/node-ci-shared.ymlmain

Copy link

@muni-corn muni-corn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a build script or build phase disabled

magonjr and others added 27 commits July 10, 2024 17:45
@TieDyedSheep
Copy link
Contributor Author

This gave me a weird conflict and the easiest way to fix it ended up with a merge commit so make sure this gets squashed when the PR is merged

@TieDyedSheep
Copy link
Contributor Author

needs a build script or build phase disabled

fixed

@TieDyedSheep TieDyedSheep requested review from afostr and a team July 22, 2024 17:16
@TieDyedSheep TieDyedSheep dismissed muni-corn’s stale review July 22, 2024 17:44

this has been fixed

@TieDyedSheep TieDyedSheep force-pushed the SYS-192-add-github-ci branch 2 times, most recently from df59844 to 73dabc9 Compare July 24, 2024 01:27
update permissions to allow for checkout of private repo in reusable workflow
fixing issue comment Pr review stuff
add codeowners and sync ci.yml

fix lint script, updated format check and fix for naming consistency
@afostr afostr force-pushed the SYS-192-add-github-ci branch from 73dabc9 to 5fc7ac3 Compare July 24, 2024 19:26
@mhanson-github mhanson-github merged commit 5fc7ac3 into dev Jul 31, 2024
7 checks passed
@mhanson-github mhanson-github deleted the SYS-192-add-github-ci branch August 20, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants