Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loaders: Add Blockscout ABI support #152

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Conversation

yohamta
Copy link
Contributor

@yohamta yohamta commented Nov 8, 2024

Resolves issue #149

Overview
This PR implements the BlockscoutABILoader to enable loading ABIs from Blockscout's API.

To do

  • Implement BlockscoutABILoader
  • Add tests

@yohamta yohamta changed the title loaders: Add blockscout abi loader loaders: Add Blockscout ABI support Nov 8, 2024
@yohamta yohamta marked this pull request as ready for review November 19, 2024 05:10
@shazow
Copy link
Owner

shazow commented Nov 20, 2024

Looks good! Anything of concern that I should take a closer look at before merging?

@yohamta
Copy link
Contributor Author

yohamta commented Nov 21, 2024

Hi @shazow, thanks for reviewing! I don't believe there are any concerns with this PR. It's ready to be merged.

@shazow shazow merged commit 96bba57 into shazow:main Nov 21, 2024
0 of 3 checks passed
@shazow
Copy link
Owner

shazow commented Nov 21, 2024

@yohamta Thank you for working on this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants