Adding EtherscanV2 #158
Closed
Adding EtherscanV2 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-thornton
force-pushed
the
dev/etherscanv2
branch
from
3d030e4 to
4816ccb
Compare
shazow
approved these changes
Nov 23, 2024
|
Merged via #163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Etherscan V2 into loaders list while I'm at it.
#157
It could have been a 3 line change, but I reconfigured the base Etherscan provider a bit since it may or may not have search params passed into it by the new subclass.
I tested permutations of the regular and new Etherscan loaders and it seemed to work across Ethereum and Base. I didn't test super thoroughly, but it seems to work!