Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gov fix (#761) #768

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Gov fix (#761) #768

merged 2 commits into from
Sep 11, 2023

Conversation

skyargos
Copy link
Contributor

@skyargos skyargos commented Sep 8, 2023

  • Fix general proposal of gov module

Closes: #XXX
Related: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]"

@skyargos
Gov fix (#761)
52a96fe 
* Fix general proposal of gov module

* Update upgrade handler

* Revert gov ConsensusVersion
@skyargos
Merge branch 'master' into gov
08412a3
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #768 (08412a3) into master (56e2a20) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   47.77%   47.76%   -0.02%     
==========================================
  Files         130      130              
  Lines       12705    12708       +3     
==========================================
  Hits         6070     6070              
- Misses       6044     6047       +3     
  Partials      591      591
Files Changed Coverage
x/gov/abci.go 0.00%

📢 Thoughts on this report? Let us know!.

@skyargos skyargos marked this pull request as ready for review September 11, 2023 08:05
@skyargos skyargos requested a review from a team as a code owner September 11, 2023 08:05
0311xuyang
0311xuyang approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@0311xuyang 0311xuyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skyargos skyargos merged commit 24cc066 into master Sep 11, 2023
@skyargos skyargos deleted the gov branch September 11, 2023 13:31
@0311xuyang 0311xuyang restored the gov branch September 15, 2023 00:30
@skyargos skyargos deleted the gov branch November 9, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-yuhh kevin-yuhh kevin-yuhh approved these changes

@0311xuyang 0311xuyang 0311xuyang approved these changes

@haozhan9 haozhan9 Awaiting requested review from haozhan9 haozhan9 is a code owner automatically assigned from shentufoundation/chain-team

@jackyi2023 jackyi2023 Awaiting requested review from jackyi2023

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skyargos @0311xuyang @kevin-yuhh