migrate bank description #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0311xuyang
reviewed
Sep 11, 2023
app/upgrade_handler.go
Outdated
| metaData := baseKeeper.GetAllDenomMetaData(ctx) | ||
|
|
||
| for _, meta := range metaData { | ||
| if meta.Description == "The native staking token of the CertiK Chain." { |
There was a problem hiding this comment.
Do we need this condition?
There was a problem hiding this comment.
we can also remove the if directly and assign the value directly.
Because although it is an array at present, the length is only 1 and will not affect other
skyargos
requested review from
0311xuyang,
yoongbok-lee,
kevin-yuhh,
haozhan9 and
jackyi2023
and removed request for
yoongbok-lee
haozhan9
reviewed
Sep 11, 2023
| if meta.Description == "The native staking token of the CertiK Chain." { | ||
| meta.Description = "The native staking token of the Shentu Chain." | ||
| } | ||
| baseKeeper.SetDenomMetaData(ctx, meta) |
There was a problem hiding this comment.
put this line in the if statement?
There was a problem hiding this comment.
we can also remove the if directly and assign the value directly.
Because although it is an array at present, the length is only 1 and will not affect other
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
==========================================
+ Coverage 47.77% 47.80% +0.02%
==========================================
Files 130 130
Lines 12705 12717 +12
==========================================
+ Hits 6070 6079 +9
- Misses 6044 6046 +2
- Partials 591 592 +1
|
haozhan9
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Related: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)