Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrefixToShentu function runs without errors using shentu address #776

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

kevin-yuhh
Copy link
Contributor

Closes: #XXX
Related: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]"

@kevin-yuhh kevin-yuhh requested a review from a team as a code owner September 19, 2023 07:30
@kevin-yuhh kevin-yuhh requested review from skyargos, yoongbok-lee, 0311xuyang and haozhan9 and removed request for yoongbok-lee September 19, 2023 07:30
Copy link
Contributor

@skyargos skyargos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin-yuhh kevin-yuhh merged commit df3da02 into master Sep 19, 2023
14 of 16 checks passed
@kevin-yuhh kevin-yuhh deleted the fix-prefixtoshentu branch September 19, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants