Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add address conversion #777

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Add address conversion #777

merged 2 commits into from
Sep 21, 2023

Conversation

skyargos
Copy link
Contributor

Closes: #XXX
Related: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]"

@skyargos skyargos requested a review from a team as a code owner September 21, 2023 16:31
0311xuyang
0311xuyang approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@0311xuyang 0311xuyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skyargos skyargos merged commit 9e47c55 into master Sep 21, 2023
14 of 16 checks passed
@skyargos skyargos deleted the addr-conversion branch September 21, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haozhan9 haozhan9 haozhan9 approved these changes

@kevin-yuhh kevin-yuhh kevin-yuhh approved these changes

@0311xuyang 0311xuyang 0311xuyang approved these changes

@yoongbok-lee yoongbok-lee Awaiting requested review from yoongbok-lee yoongbok-lee is a code owner automatically assigned from shentufoundation/chain-team

@jackyi2023 jackyi2023 Awaiting requested review from jackyi2023 jackyi2023 is a code owner automatically assigned from shentufoundation/chain-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skyargos @0311xuyang @kevin-yuhh @haozhan9