Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: complete github action [SHFT-1] #7

Merged
merged 18 commits into from
Oct 11, 2023
Merged

feat: complete github action [SHFT-1] #7

merged 18 commits into from
Oct 11, 2023

Conversation

nejdetkadir
Copy link
Member

@nejdetkadir nejdetkadir commented Oct 11, 2023 •
edited
Loading

Checklist

  • I've reviewed my code. (*)
  • Does this task have an ID?
  • Should this task be tested by testers? (*)
  • Is there a need to add new translations
    • I've placed all translations in the appropriate JSON files. (*)
    • I've verified that the translations work as expected in different languages. (*)
  • Are there any UI changes?
    • Screenshots or screen recordings of the changes have been attached to the PR. (*)
  • No unnecessary console logs or commented out code remains. (*)
  • I didn't hard-code any sensitive information.(*)
  • I've tested browser compatibility. (e.g. Chrome, Safari, Mozilla, Opera) (*)
  • All new and existing tests have passed. (*)
  • I've checked for potential performance issues. (e.g. slow component mounting, too many HTTP requests, unnecessary re-renders) (*)
  • I've addressed accessibility concerns. (*)
  • I've added a new dependency.
    • I've checked that all newly added dependencies are secure and up-to-date. (*)
  • The PR contains only changes related to the task at hand. If there are any changes outside of the task, I've mentioned them in the description. (*)

Related Issue Link(s): ...

Description: ...
Screenshot 2023-10-11 at 20 59 54

@nejdetkadir nejdetkadir self-assigned this Oct 11, 2023
@nejdetkadir nejdetkadir removed the request for review from sonergonencler October 11, 2023 16:32
@nejdetkadir nejdetkadir removed their assignment Oct 11, 2023
@nejdetkadir nejdetkadir changed the title feat: complete github action eat: complete github action Oct 11, 2023
@nejdetkadir nejdetkadir changed the title eat: complete github action feat: complete github action Oct 11, 2023
@nejdetkadir nejdetkadir self-assigned this Oct 11, 2023
@nejdetkadir nejdetkadir changed the title feat: complete github action feat: complete github action [SHFT-1] Oct 11, 2023
sonergonencler
sonergonencler reviewed Oct 11, 2023
View reviewed changes
src/hooks/useInputs.ts Outdated Show resolved Hide resolved
src/lib/markdownParser.ts Outdated Show resolved Hide resolved
@nejdetkadir nejdetkadir merged commit f378a55 into main Oct 11, 2023
2 of 3 checks passed
@nejdetkadir nejdetkadir deleted the feature/complete-github-action branch October 11, 2023 18:15
@nejdetkadir
Copy link
Member Author

BOT MESSAGE 🤖

  • 🔴 Pull request must have at least one reviewer.

@nejdetkadir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonergonencler sonergonencler sonergonencler left review comments

Assignees

@nejdetkadir nejdetkadir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nejdetkadir @sonergonencler