Skip to content

Commit

Permalink
Merge pull request #45 from shiguredo/feature/add-forwardingfilter-ve…
Browse files Browse the repository at this point in the history
…rsion-metadata

ForwardingFilter に version と metadata を追加する
  • Loading branch information
miosakuma committed Jan 19, 2024
2 parents 229df99 + 3e19d45 commit cc3d0b9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
5 changes: 4 additions & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,17 @@
- @tnoho
- [ADD] AudioStreamSink が返す音声フレームとして pickel が可能な AudioFrame を追加
- @tnoho
- [UPDATE] Sora C++ SDK のバージョンを 2023.17.0 に上げる
- [UPDATE] Sora C++ SDK のバージョンを 2024.1.0 に上げる
- WebRTC m116 で cricket::Codec は protected になったので cricket::CreateVideoCodec に修正する
- WebRTC m118 でパッケージディレクトリが変更されたためそれに追従する
- WebRTC m120 の webrtc::EncodedImage API の変更に追従する
- WEBRTC_BUILD_VERSION を `m120.6099.1.2` に上げる
- BOOST_VERSION を `1.83.0` に上げる
- CMAKE_VERSION を `3.27.7` に上げる
- @voluntas @miosakuma
- [UPDATE] ForwardingFilter に version と metadata を追加する
- Sora 2023.2.0, C++ SDK 2024.1.0 への追従
- @miosakuma
- [UPDATE] JetPack を 5.1.2 に上げる
- @miosakuma

Expand Down
6 changes: 6 additions & 0 deletions src/sora.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,12 @@ Sora::ConvertForwardingFilter(const nb::handle value) {
}
filter.rules.push_back(rules);
}
if (!object["version"].is_null()) {
filter.version = std::string(object["version"].as_string());
}
if (!object["metadata"].is_null()) {
filter.metadata = object["metadata"];
}
} catch (std::exception&) {
throw nb::type_error("Invalid forwarding_filter");
}
Expand Down

0 comments on commit cc3d0b9

Please sign in to comment.