Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

名前のなかった引数に名前を追加 #35

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Conversation

tnoho
Copy link
Contributor

@tnoho tnoho commented Sep 3, 2023

これまで、名前のなかった引数に利便性の向上のため名前をつけたいと思います。名前は他のものと揃えて C++ の引数名を使うこととしました。

@tnoho tnoho requested a review from voluntas September 3, 2023 14:43
@tnoho tnoho self-assigned this Sep 3, 2023
@voluntas voluntas requested a review from sile September 4, 2023 01:07
Copy link
Member

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@voluntas
Copy link
Member

voluntas commented Sep 4, 2023

ドキュメントマージ後にマージします。

@miosakuma
Copy link
Contributor

ドキュメントがマージされたためこちらもマージします

@miosakuma miosakuma merged commit 66c8245 into develop Sep 21, 2023
13 checks passed
@miosakuma miosakuma deleted the feature/overhaul branch September 21, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants