Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes mainly focused on code simplification, performance improvement, and updating dependencies. The most significant changes are the replacement of
nb::shape<nb::any, nb::any>
withnb::shape<-1, -1>
in several files, the update of thenanobind
dependency inpyproject.toml
, and the addition of new file associations in.vscode/settings.json
.Code simplification and performance improvement:
src/sora_audio_sink.cpp
,src/sora_audio_sink.h
,src/sora_audio_source.cpp
,src/sora_audio_source.h
,src/sora_audio_stream_sink.cpp
,src/sora_audio_stream_sink.h
,src/sora_video_sink.cpp
,src/sora_video_sink.h
,src/sora_video_source.cpp
,src/sora_video_source.h
,src/sora_sdk_ext.cpp
: Replacednb::shape<nb::any, nb::any>
withnb::shape<-1, -1>
to simplify the code and potentially improve performance. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Dependency update:
pyproject.toml
: Updated thenanobind
dependency from1.9.2
to2.0.0
.File associations:
.vscode/settings.json
: Added new file associations for.cs
andCMakeLists.txt
files, and addedcompare
andconcepts
to the list of cpp files. [1] [2]Performance improvement:
run.py
: Modified thecmake
command to use all available CPU cores during the build process.Code addition:
run.py
: Imported themultiprocessing
module to get the number of available CPU cores.