-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on_signaling_message を追加します #81
Conversation
C++ SDK では C++ 的な書き方で
としたが、Python SDK では引数の省略が文化的に強いので引数を重要度順並び替え
としたいと思うがいかがだろうか。 |
…python-sdk into feature/add-on-signaling
@tnoho |
GJ !! |
shiguredo/sora-cpp-sdk#121 と連動します。詳細は Sora C++ SDK の PR を参照してください。
This pull request introduces several significant updates and new features to the project, including the addition of a new callback for signaling messages, version updates, and enhancements to the media example. Below is a summary of the most important changes:
New Features and Enhancements:
Added a new
on_signaling_message
callback to handle various signaling messages inexamples/src/media/__init__.py
. This includes new properties for different message types and a new_on_signaling_message
method to process these messages. [1] [2] [3]Updated
CHANGES.md
to document the addition of theon_signaling_message
callback.Added a new test
test_signaling_message
inexamples/tests/test_signaling_message.py
to verify the functionality of the new signaling message handling.Version Updates:
Sora C++ SDK
version to2024.8.0-canary.1
in theVERSION
file.Codebase Enhancements:
Included necessary headers and updated method implementations in
src/sora_connection.cpp
andsrc/sora_connection.h
to support the new signaling message callback. [1] [2] [3]Added new enums for
SoraSignalingType
andSoraSignalingDirection
insrc/sora_sdk_ext.cpp
and exposed theon_signaling_message
callback to Python. [1] [2]These changes enhance the signaling capabilities of the project and ensure proper handling and testing of signaling messages.