Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_signaling_message を追加します #81

Merged
merged 13 commits into from
Sep 14, 2024
Merged

Conversation

tnoho
Copy link
Contributor

@tnoho tnoho commented Sep 9, 2024

shiguredo/sora-cpp-sdk#121 と連動します。詳細は Sora C++ SDK の PR を参照してください。


This pull request introduces several significant updates and new features to the project, including the addition of a new callback for signaling messages, version updates, and enhancements to the media example. Below is a summary of the most important changes:

New Features and Enhancements:

  • Added a new on_signaling_message callback to handle various signaling messages in examples/src/media/__init__.py. This includes new properties for different message types and a new _on_signaling_message method to process these messages. [1] [2] [3]

  • Updated CHANGES.md to document the addition of the on_signaling_message callback.

  • Added a new test test_signaling_message in examples/tests/test_signaling_message.py to verify the functionality of the new signaling message handling.

Version Updates:

  • Updated the Sora C++ SDK version to 2024.8.0-canary.1 in the VERSION file.

Codebase Enhancements:

  • Included necessary headers and updated method implementations in src/sora_connection.cpp and src/sora_connection.h to support the new signaling message callback. [1] [2] [3]

  • Added new enums for SoraSignalingType and SoraSignalingDirection in src/sora_sdk_ext.cpp and exposed the on_signaling_message callback to Python. [1] [2]

These changes enhance the signaling capabilities of the project and ensure proper handling and testing of signaling messages.

@tnoho tnoho self-assigned this Sep 9, 2024
@tnoho tnoho changed the title on_signaling を追加します on_signaling_message を追加します Sep 13, 2024
@tnoho
Copy link
Contributor Author

tnoho commented Sep 14, 2024

C++ SDK では C++ 的な書き方で

OnSignalingMessage(sora::SoraSignalingType type, sora::SoraSignalingDirection direction, std::string message)

としたが、Python SDK では引数の省略が文化的に強いので引数を重要度順並び替え

OnSignalingMessage(std::string message, sora::SoraSignalingDirection direction, sora::SoraSignalingType type)

としたいと思うがいかがだろうか。

@tnoho tnoho marked this pull request as ready for review September 14, 2024 02:27
@tnoho tnoho requested a review from voluntas September 14, 2024 02:27
@voluntas
Copy link
Member

@tnoho OnSignalingMessage(sora::SoraSignalingType type, sora::SoraSignalingDirection direction, std::string message) 引数省略なしで、大丈夫です 🆗

@voluntas
Copy link
Member

GJ !!

@voluntas voluntas merged commit 5c75415 into develop Sep 14, 2024
3 checks passed
@voluntas voluntas deleted the feature/add-on-signaling branch September 14, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants