Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update oniguruma-to-es and use new api #886

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

slevithan
Copy link
Collaborator

  • Bumps oniguruma-to-es from 0.10.0 to ^1.0.0.
    • Adds rules.recursionLimit and sets it to 5. This reproduces the default behavior of v0.3.0 to v0.10.0.
      • v1.0.0 changed the default recursion depth limit to 20 to match Oniguruma.
    • v1.0.0 drops support for the CodeQL grammar because it contains an invalid Oniguruma regex that oniguruma-to-es is now able to detect (use of lookahead within lookbehind).
      • The grammar works the same in the Oniguruma and JS RegExp engines if forgiving is enabled.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for shiki-next failed.

Name Link
🔨 Latest commit c63876a
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/677e94c4addaa100088d3458

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit c63876a
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/677e94c497ac150008e3ee2b
😎 Deploy Preview https://deploy-preview-886--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu antfu merged commit cffde36 into shikijs:main Jan 8, 2025
8 of 12 checks passed
@slevithan slevithan deleted the onigtoesv1 branch January 8, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants