optimise one

shikokuchuo · Nov 23, 2023 · c5a490f · c5a490f
1 parent c81f134
commit c5a490f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: nanonext
 Type: Package
 Title: NNG (Nanomsg Next Gen) Lightweight Messaging Library
-Version: 0.10.4.9011
+Version: 0.10.4.9012
 Description: R binding for NNG (Nanomsg Next Gen), a successor to ZeroMQ. NNG is
     a socket library implementing 'Scalability Protocols', a reliable,
     high-performance standard for common communications patterns including

diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,4 @@
-# nanonext 0.10.4.9011 (development)
+# nanonext 0.10.4.9012 (development)
 
 #### New Features
 
@@ -13,7 +13,7 @@
   + registered 'refhook' functions apply to external pointer type objects only.
 * `until()` updated to be identical to `.until()`, returning FALSE instead of TRUE if the timeout has been reached.
 * `pipe_notify()` arguments 'add', 'remove' and 'flag' now default to FALSE instead of TRUE for easier selective specification of the events to signal.
-* Fixes potential segfault at `ncurl()` when the relocation address is missing and 'follow' is set to TRUE.
+* Fixes regression in release 0.10.4 that caused a potential segfault using `ncurl()` with 'follow' set to TRUE when the server returns a missing or invalid relocation address.
 * The weak references interface is removed as 'non-core'.
 * Applies fix nanomsg/nng#1702 to bundled 'libnng' v1.6.0 (a54820f).
 * Upgrades bundled 'libmbedtls' to v 3.5.1.

diff --git a/src/thread.c b/src/thread.c
@@ -377,7 +377,6 @@ SEXP rnng_signal_thread_create(SEXP cv, SEXP cv2) {
   SEXP xptr = R_MakeExternalPtr(duo, R_NilValue, R_NilValue);
   Rf_setAttrib(cv, nano_CvSymbol, xptr);
   R_RegisterCFinalizerEx(xptr, thread_duo_finalizer, TRUE);
-  R_MakeWeakRef(xptr, cv, R_NilValue, FALSE);
 
   return cv2;