Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncurlAio promises implementation #34

Merged
merged 3 commits into from
Jun 21, 2024
Merged

ncurlAio promises implementation #34

merged 3 commits into from
Jun 21, 2024

Conversation

shikokuchuo
Copy link
Owner

Closes #33

@shikokuchuo shikokuchuo self-assigned this Jun 20, 2024
@shikokuchuo shikokuchuo added the enhancement New feature or request label Jun 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.14%. Comparing base (c9f135b) to head (7d1d859).

Files Patch % Lines
R/ncurl.R 72.22% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   89.57%   90.14%   +0.56%     
==========================================
  Files          23       23              
  Lines        3175     3195      +20     
==========================================
+ Hits         2844     2880      +36     
+ Misses        331      315      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shikokuchuo shikokuchuo merged commit 9efc5d8 into main Jun 21, 2024
8 checks passed
@shikokuchuo shikokuchuo deleted the promising branch June 21, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement event-driven ncurl HTTP request promises
2 participants