Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use global websocket #208

Draft
wants to merge 5 commits into
base: wip/v5
Choose a base branch
from
Draft

feat: use global websocket #208

wants to merge 5 commits into from

Conversation

0t4u
Copy link
Member

@0t4u 0t4u commented Nov 13, 2024

A native WebSocket implementation was marked stable in Node 22.4.0.

Removes "ws" dependency and bumps minimum Node version to 22.4.0.

Performance impact has not yet been measured, backpressure is not handled according to spec, some investigation into this is required.

@0t4u 0t4u requested a review from Deivu as a code owner November 13, 2024 15:32
@0t4u 0t4u marked this pull request as draft November 13, 2024 15:34
@aetherpw
Copy link

aetherpw commented Nov 16, 2024

Using this in production is premature, as the native WebSocket implementation is not yet reliable.
It has yet to pass the Autobahn test, making it unsuitable for production use.
Additionally, the last time I checked, it wasn’t even usable and performed significantly worse than websockets/ws, a more mature and battle-tested solution.

Until it demonstrates readiness through passing the Autobahn test and providing credible performance benchmarks, adoption should not be considered.

@0t4u 0t4u added the blocked Something is preventing this pull from being merged/issue from being solved label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something is preventing this pull from being merged/issue from being solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants