-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Middleware deduping #3012
base: main
Are you sure you want to change the base?
Middleware deduping #3012
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@patrikholcak is attempting to deploy a commit to the shipshapecode Team on Vercel. A member of the Team first needs to authorize it. |
@patrikholcak we have been talking about this recently and I recently released a change that changes the ordering, so that a dup added in would run last, but that still could have issues. This would be onus on the user to make sure they still have sane defaults when going down this path, but does give the most control. |
@patrikholcak docs failed to build due to this error |
a5bd5fc
to
ee832a5
Compare
Rebased and updated. I also updated a step test which was failing due to the changes in dfb7d74. I’m not sure the test is relevant now, can probably be removed altogether 🤷 |
About
This might be a controversial (and breaking) change, but instead of overriding middlewares, I think the step middleware should always win. Feel free to close this PR or message me to make changes.
Take this example:
To override
defaultStepOptions
you need equal negative spacing and sync these two numbers every time the default changes (or have a constant)With this PR:
The step offset middleware overrides the default step middleware