I improved routine to update externals option #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was the BREKING CHANGE of renaming tapAsync hook. fix shirotech#63
It was the BREKING CHANGE of renaming tapAsync hook. fix shirotech#63
This improvement fixes shirotech#81 It was caused by overwriting externals configuration without checking.
…ojbect. This modification fixes shirotech#81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I improved routine to update externals configuration option in module.
This improvement will fix some problems about external configuration option.
I might think that changing 'var' option behavior is easy to understand what this plugin do.
var:string(optional)A variable that will be assigned to the module in global scope, webpack requires this. This option will overwrite externals configuration option, If supplied.