Skip to content

Commit

Permalink
fix event on fullscreen of Edge
Browse files Browse the repository at this point in the history
  • Loading branch information
Masashi Hirano committed Aug 26, 2017
1 parent a55c839 commit e893f60
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
9 changes: 5 additions & 4 deletions lib/toggleFullscreen.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ var Promise = require('es6-promise').Promise;
function toggleFullscreen(element, callback) {
if (callback) {
if (!isFullscreen()) {
enterFullscreen(element);
fullScreenChange(function() {
if (isFullscreen()) {
callback(true);
} else {
callback(false);
}
});
enterFullscreen(element);
} else {
exitFullscreen();
callback(false);
Expand All @@ -23,14 +23,14 @@ function toggleFullscreen(element, callback) {
}
return new Promise(function(resolve, reject) {
if (!isFullscreen()) {
enterFullscreen(element);
fullScreenChange(function() {
if (isFullscreen()) {
resolve(true);
} else {
resolve(false);
}
});
enterFullscreen(element);
} else {
exitFullscreen();
resolve(false);
Expand Down Expand Up @@ -65,7 +65,7 @@ function toggleFullscreen(element, callback) {
} else if (element.mozRequestFullScreen) {
element.parentElement.mozRequestFullScreen();
} else if (element.webkitRequestFullscreen) {
element.webkitRequestFullscreen(Element.ALLOW_KEYBOARD_INPUT);
element.webkitRequestFullscreen();
}
}

Expand Down Expand Up @@ -94,7 +94,8 @@ function toggleFullscreen(element, callback) {
} else if (document.mozFullScreenEnabled) {
document.addEventListener('mozfullscreenchange',callback);
} else if (document.webkitFullscreenEnabled) {
document.addEventListener('webkitfullscreenchange', callback);
document.addEventListener('webkitfullscreenchange', callback); //Safari
document.addEventListener('fullscreenChange', callback); // Edge
} else if (document.msFullscreenEnabled) {
document.addEventListener('MSFullscreenChange', callback);
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "toggle-fullscreen",
"version": "0.2.1",
"version": "0.2.2",
"description": "Simple to use Fullscreen API with Promise for cross-browser.",
"main": "index.js",
"scripts": {
Expand Down

0 comments on commit e893f60

Please sign in to comment.