Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/logout #51

Merged
merged 4 commits into from
May 19, 2024
Merged

Feature/logout #51

merged 4 commits into from
May 19, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented May 19, 2024

Implement logout logic, including an item in the header.

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 71.70%. Comparing base (3b65c19) to head (00f2b30).
Report is 1 commits behind head on main.

Files Patch % Lines
app/root.tsx 0.00% 28 Missing ⚠️
app/common/MainHeader.tsx 94.28% 0 Missing and 2 partials ⚠️
app/tags/TagsService.server.ts 33.33% 0 Missing and 2 partials ⚠️
app/auth/session-context.ts 91.66% 0 Missing and 1 partial ⚠️
app/routes/logout.ts 90.00% 0 Missing and 1 partial ⚠️
app/routes/server.$serverId.$.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   71.54%   71.70%   +0.16%     
==========================================
  Files          23       25       +2     
  Lines         875      933      +58     
  Branches      100      103       +3     
==========================================
+ Hits          626      669      +43     
- Misses        149      161      +12     
- Partials      100      103       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit c54ea4f into shlinkio:main May 19, 2024
5 of 6 checks passed
@acelaya acelaya deleted the feature/logout branch May 19, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant