Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create settings page #52

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented May 20, 2024

Closes #26

Add a new /settings route where users can edit their application settings as long as they are logged in.

The route renders a ShlinkWebSettings instance from @shlinkio/shlink-web-component/settings.

This PR also adds the logic to apply selected theme to the markup.

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 61.36364% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 71.34%. Comparing base (00f2b30) to head (e275876).
Report is 1 commits behind head on main.

Files Patch % Lines
app/routes/settings.$.tsx 60.00% 19 Missing and 3 partials ⚠️
app/root.tsx 0.00% 9 Missing ⚠️
app/settings/SettingsService.server.ts 81.81% 0 Missing and 2 partials ⚠️
app/routes/server.$serverId.$.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   71.70%   71.34%   -0.37%     
==========================================
  Files          25       26       +1     
  Lines         933     1012      +79     
  Branches      103      113      +10     
==========================================
+ Hits          669      722      +53     
- Misses        161      177      +16     
- Partials      103      113      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya marked this pull request as ready for review May 21, 2024 16:16
@acelaya acelaya merged commit 98e29cb into shlinkio:main May 22, 2024
4 of 6 checks passed
@acelaya acelaya deleted the feature/settings-section branch May 22, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add settings configuration page
1 participant