Permit empty collection of vars in example file #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hapipal/boilerplate#91 (comment) it was mentioned that the hapipal boilerplate's use-case for having empty☺️
.envand.env.examplefiles seemed reasonable and that a PR would be welcome. This is that PRTo document the use-case: the boilerplate supports a single, optional
PORTenvironment variable with a default set via runtime validation. It's desired to not force the user to fill this environment variable in manually during installation. The standard way to handle optional variables with envy is to just leave them commented-out in.env.example, but in our case that would result in an empty example file, which envy does not allow. This PR removes the check for an empty example file, which is a breaking change.