Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move api-gen package to biome #1499

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Nov 29, 2024

switched api-gen package linting to biome for better accuracy and performance
test: time pnpm run lint inside package

before

pnpm run lint  4.95s user 0.52s system 150% cpu 3.644 total

after

pnpm run lint  0.33s user 0.13s system 85% cpu 0.540 total

apart of the speed it was more accurate in finding problems and making the code more consistent

@patzick patzick requested a review from mkucmus November 29, 2024 13:32
Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Dec 2, 2024 11:51am
1 Skipped Deployment
Name Status Preview Updated (UTC)
shopware-frontends-docs ⬜️ Skipped (Inspect) Dec 2, 2024 11:51am

Copy link

pkg-pr-new bot commented Nov 29, 2024

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1499

@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1499

@shopware-pwa/cms-base

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/cms-base@1499

@shopware-pwa/composables-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/composables-next@1499

@shopware-pwa/helpers-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/helpers-next@1499

@shopware-pwa/nuxt3-module

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/nuxt3-module@1499

commit: 0240c2d

Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #1499 will degrade performances by 81.34%

Comparing feat/move-api-gen-package-to-biome (0240c2d) with main (59844aa)

Summary

⚡ 1 improvements
❌ 2 (👁 2) regressions
✅ 6 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/move-api-gen-package-to-biome Change
👁 [api-client][createAdminAPIClient] - creating client 123.8 µs 145.1 µs -14.66%
👁 [api-client][transformPathToQuery] - transform with path params 72.2 µs 386.7 µs -81.34%
[api-client][transformPathToQuery] - transform with path,query,body,header params 299.4 µs 83.1 µs ×3.6

@patzick patzick merged commit a965e10 into main Dec 2, 2024
13 checks passed
@patzick patzick deleted the feat/move-api-gen-package-to-biome branch December 2, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants