Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing title prefix on the cards component page #3358

Conversation

87xie
Copy link
Contributor

@87xie 87xie commented Oct 3, 2024

Why:

Closes: N/A

I noticed the Card Components documentation page is missing a title prefix, so I added __nextra_dynamic_opts.title: 'Card Components' to the static props to ensure the page has a proper title.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Before

image

After

image

image

Check off the following:

  • I have reviewed my changes in staging, available via the View
    deployment
    link in this PR's timeline (this link will be available after
    opening the PR).

    • For content changes, you will also see an automatically generated comment
      with links directly to pages you've modified. The comment won't appear if
      your PR only edits files in the data directory.
  • For content changes, I have completed the
    self-review checklist.

Copy link

changeset-bot bot commented Oct 3, 2024

⚠️ No Changeset found

Latest commit: 8d39c81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 5:02pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 5:02pm

Copy link

vercel bot commented Oct 3, 2024

@87xie is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@dimaMachina
Copy link
Collaborator

🙏 thanks

@dimaMachina dimaMachina merged commit 7b919a2 into shuding:main Oct 3, 2024
6 of 9 checks passed
@87xie 87xie deleted the fix-missing-title-prefix-on-the-cards-component-page branch October 8, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants