Implement label for Y Axis Add editorconfig file #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frco9
pushed a commit
to frco9/rickshaw
that referenced
this pull request
Mar 26, 2014
Credits to wangshijun2010, pull request shutterstock#404
|
@dchester Could you please verify this PR and comment your opinion about it? I think this is very useful feature. |
| [*] | ||
|
|
||
| # Change these settings to your own preference | ||
| indent_style = space |
There was a problem hiding this comment.
Rickshaw source code is indented with tabs!
|
2 things in one PR is probably not the best idea |
|
@wangshijun If you are still interested in getting this PR in, would you mind submitting a separate PR for the editorconfig? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes are made:
labels for x axis currently is not supported