-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for multiple cloudformation stacks (Add apiId) #647
Draft
plezan
wants to merge
37
commits into
sid88in:master
Choose a base branch
from
plezan:feat/Support-apiId(Multiple-cloudformation-stacks)
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: add support for multiple cloudformation stacks (Add apiId) #647
plezan
wants to merge
37
commits into
sid88in:master
from
plezan:feat/Support-apiId(Multiple-cloudformation-stacks)
+1,691
−1,156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master'
fix: support serverless >= 4.0.23 (sid88in#632)
fix: Deployment using serverless-compose
Also tested without any issue with serverless-appsync-simulator using serverless v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #597, updated to be mergeable on master.
I tried to follow @bboure review comments on the original PR.
The goal of this PR is to add support for splited appsync config across multiple services. This is required to bypass the 500 resources limit on cloud formation stacks.
Since the support for Serverless v3 will be dropped at the end of the year, I mainly focused on making those changes compatipble with sls v4.
Main changes
apiId
to appsync config to allow adding resources to an existing appsync apiWhat else changed in the project ?
To be be properly compatible with serverless v4 and serverless compose i needed to make a few other changes :
Status
Tested with:
Not tested with:
The code and documentation still need some cleanup work.
Any feedback is welcome !