Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix improper activeThreads increments (issue 1842) #1845

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix improper activeThreads increments (issue 1842) #1845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions modules/siddhi-core/src/main/java/io/siddhi/core/util/ThreadBarrier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,23 @@ public class ThreadBarrier {

private ReentrantLock lock = new ReentrantLock();
private AtomicInteger counter = new AtomicInteger();
private ThreadLocal<MutableInteger> localEnters = ThreadLocal.withInitial(() -> new MutableInteger(0));

public void enter() {
if (localEnters.get().incrementAndGet() > 1) {
return;
}
if (lock.isLocked()) {
lock.lock();
lock.unlock();
}
counter.incrementAndGet();
}


public void exit() {
counter.decrementAndGet();
if (localEnters.get().decrementAndGet() == 0) {
counter.decrementAndGet();
}
}

public int getActiveThreads() {
Expand All @@ -54,4 +59,24 @@ public void unlock() {
lock.unlock();
}

/**
* Simple non-thread-safe integer wrapper to be used in ThreadLocal
*/
private static class MutableInteger {

private int value;

public MutableInteger(int initialValue) {
this.value = initialValue;
}

public int incrementAndGet() {
return ++value;
}

public int decrementAndGet() {
return --value;
}
}

}