Skip to content

Commit

Permalink
ENG-3379 : Replace coverall code coverage with 'CodeCov' in Sightmach…
Browse files Browse the repository at this point in the history
…ine-SDK (#57)

* Adding CodeCov to circleCI

1) Replaced coverall code coverage in Sightmachine-SDK with CodeCov
2) Fixed a static type error in mas_session.py

* Addressing comments from the code review
  • Loading branch information
JMkrish authored Nov 13, 2023
1 parent a40f96c commit f03b91a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
10 changes: 8 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ workflows:
orbs:
gcp-gke: circleci/gcp-gke@0.2.0
python: circleci/python@2.1.1
codecov: codecov/codecov@3.3.0

commands:
disable_docker_hub:
Expand Down Expand Up @@ -58,10 +59,15 @@ jobs:
- run:
name: Run Unit Tests
command: |
set -x
pip install -r requirements-codecoverage.txt
mkdir test-results
coverage run -m pytest --junitxml=test-results/junit.xml tests
coverage report
coverage html
- run:
name: Compile Coverage Report
command: |
coverage html -d htmlcov
codecov --required
# Store the test results on each node so we can see failures
- store_test_results:
Expand Down
4 changes: 2 additions & 2 deletions requirements-coveralls.txt → requirements-codecoverage.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Use public repo for coverall upload

coverage==6.5.0
coveralls
codecov==2.1.13
coverage==7.3.2

0 comments on commit f03b91a

Please sign in to comment.