Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #656: attempt to find runs in subtitle if not in title #657

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

gotofritz
Copy link
Contributor

@gotofritz gotofritz commented Oct 5, 2024

Sometimes the object 'runs' is not to be found within title, but within
subtitle. This PR makes ytmusicapi look in both places.

Closes #656

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.03%. Comparing base (e995ae5) to head (0138c18).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ytmusicapi/parsers/playlists.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   95.15%   95.03%   -0.13%     
==========================================
  Files          38       38              
  Lines        2290     2274      -16     
==========================================
- Hits         2179     2161      -18     
- Misses        111      113       +2     
Flag Coverage Δ
unittests 95.03% <91.66%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sigma67
Copy link
Owner

sigma67 commented Oct 7, 2024

@gotofritz I would like to merge the fix but as you can tell from the pipeline I cannot reproduce.. In the second commit I removed your fix and the result is the same, no crash (despite adding a test for the playlist you provided).

It seems this bug is only present when you own the playlist?

Here is a screenshot what it looks like for me, logged in.

image

You could also test if the issue also occurs with a non-authenticated account for you.

@gotofritz
Copy link
Contributor Author

Yeah it's not happening any more, it must have been a short lived glitch. The playlists have titles again and they now appear in my list. FYI, my account was suspended out of the blue for three hours and then restored, not sure what happened there but this must have been part of it. Thanks for your time, not sure what you want to do with this PR now, up to you.

@sigma67 sigma67 merged commit 2b5d19a into sigma67:main Oct 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unable to find 'runs' using path ['title', 'runs', 0, 'text'] on {}
2 participants