Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update population.md / found a repetition #188

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

TimothyRbz
Copy link
Contributor

@TimothyRbz TimothyRbz commented Dec 9, 2024

Just noticed this repetition, and trying to get used to edit (commit) in GitHub.

Fixes

Fixes #[issue number] by @[issue author]

Description

Technical details

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow the contribution guidelines.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
Further Conditions
(e) This contribution does not grant me any rights to use the
    name of the project, the name of the author, the name of the
    organization, or the name of the author's organization in any
    advertising or publicity relating to this project or the
    contribution.
(f) This contribution does not grant me rights to any trademark or service
    mark belonging to the project, the author, the organization, or the
    author's organization.

Just noticed this repetition, and trying to get used to edit (commit) in GitHub.
@@ -54,7 +54,7 @@ From our research, it is unclear how many people use sign languages.
[^wfd]: World Federation of the Deaf. 2024. [Our Work](https://wfdeaf.org/our-work/).
[^un-national-day]: United Nations. 2024. [International Day of Sign Languages](https://www.un.org/en/observances/sign-languages-day).

It is unclear how many people use sign languages.
It is unclear how many people use sign languages. (Comment: This sentence is a repetition of the sentence before, the one before is better)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making your first contribution.
If you want to remove the sentence, you should remove the sentence. Then, you can either leave a comment directly on the line of what you did (same as i am leaving now) or your can write it under "conversation" instead of the unfilled template.

if this was just the removal of this sentence, it would have been approved 👍🏻

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I dont see where the "conversation" section is? Do you mean the "Extended description" section in "poposed changes window" ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you create a PR, you are writing the first item in "conversation"

image

@AmitMY AmitMY merged commit 73f7be0 into master Dec 11, 2024
1 check failed
@AmitMY AmitMY deleted the TimothyRbz-patch-1 branch December 11, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants