Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] add tests for Java auto-instrumentation #1131

Merged
merged 7 commits into from
Feb 6, 2024
Merged

[chore] add tests for Java auto-instrumentation #1131

merged 7 commits into from
Feb 6, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 26, 2024

Description:
Add tests with Apache Tomcat, sending spans every second.

@atoulme atoulme requested review from a team as code owners January 26, 2024 08:50
jvoravong
jvoravong requested changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@jvoravong jvoravong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the test failures were just random, turns out they are reproducible. We'll have to fix these tests first.

atoulme and others added 2 commits January 26, 2024 08:06
@atoulme @jvoravong
Update functional_tests/testdata/java/Makefile
be49db5 
Co-authored-by: jvoravong <47871238+jvoravong@users.noreply.github.com>
@atoulme @jvoravong
Update functional_tests/testdata/java/README.md
be414e1 
Co-authored-by: jvoravong <47871238+jvoravong@users.noreply.github.com>
@atoulme
Copy link
Contributor Author

atoulme commented Jan 26, 2024

I thought the test failures were just random, turns out they are reproducible. We'll have to fix these tests first.

Working on it

@atoulme
Copy link
Contributor Author

atoulme commented Jan 26, 2024

I have found that the docker image for java was not in a public repository, fixing that. Trying.

@atoulme atoulme merged commit 0de5329 into main Feb 6, 2024
32 checks passed
@atoulme atoulme deleted the java_test branch February 6, 2024 00:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jvoravong jvoravong jvoravong approved these changes

@jinja2 jinja2 jinja2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atoulme @jinja2 @jvoravong