Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>
  • Loading branch information
paulhauner and jimmygchen authored Jul 18, 2023
1 parent 9ff1679 commit 1766dbd
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion book/src/validator-manager.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ downtime.
The `validator-manager` boasts the following features:

- One-line command to arbitrarily move validators between two VCs, maintaining the slashing protection database.
- Generates deposit files compatible with the [Ethereum Staking Launchpad]().
- Generates deposit files compatible with the [Ethereum Staking Launchpad][].
- Generally involves zero or very little downtime.
- The "key cache" is preserved whenever a validator is added with the validator
manager, preventing long waits at start up when a new validator is added.
Expand Down
2 changes: 0 additions & 2 deletions validator_client/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ pub fn cli_app<'a, 'b>() -> App<'a, 'b> {
.arg(
Arg::with_name("http-allow-keystore-export")
.long("http-allow-keystore-export")
.value_name("ORIGIN")
.help("If present, allow access to the DELETE /lighthouse/keystores HTTP \
API method, which allows exporting keystores and passwords to HTTP API \
consumers who have access to the API token. This method is useful for \
Expand All @@ -219,7 +218,6 @@ pub fn cli_app<'a, 'b>() -> App<'a, 'b> {
.arg(
Arg::with_name("http-store-passwords-in-secrets-dir")
.long("http-store-passwords-in-secrets-dir")
.value_name("ORIGIN")
.help("If present, any validators created via the HTTP will have keystore \
passwords stored in the secrets-dir rather than the validator \
definitions file.")
Expand Down
2 changes: 1 addition & 1 deletion validator_manager/src/create_validators.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ pub fn cli_app<'a, 'b>() -> App<'a, 'b> {
Arg::with_name(FIRST_INDEX_FLAG)
.long(FIRST_INDEX_FLAG)
.value_name("FIRST_INDEX")
.help("The first of consecutive key indexes you wish to recover.")
.help("The first of consecutive key indexes you wish to create.")
.takes_value(true)
.required(false)
.default_value("0"),
Expand Down

0 comments on commit 1766dbd

Please sign in to comment.