Skip to content

Commit

Permalink
Remove Node.js from release-tests CI job since we no longer use ganac…
Browse files Browse the repository at this point in the history
…he (#4691)

## Issue Addressed

I noticed a node.js version warning on our CI, and thought about updating the version to get rid of this warning, but then realized we may not need node.js anymore now we're using `anvil` instead of `ganache`.

> The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
  • Loading branch information
jimmygchen committed Sep 6, 2023
1 parent 0caf2af commit 1ff4033
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions .github/workflows/test-suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,6 @@ jobs:
- name: Get latest version of stable Rust
if: env.SELF_HOSTED_RUNNERS == false
run: rustup update stable
- name: Use Node.js
uses: actions/setup-node@v2
with:
node-version: '14'
- name: Install windows build tools
run: |
choco install python visualstudio2019-workload-vctools -y
npm config set msvs_version 2019
- name: Install Foundry (anvil)
uses: foundry-rs/foundry-toolchain@v1
with:
Expand Down

0 comments on commit 1ff4033

Please sign in to comment.