Minor review tweaks

sigp · Apr 4, 2024 · 2a83bdb · 2a83bdb
1 parent ea69ec9
commit 2a83bdb
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/beacon_node/src/config.rs b/beacon_node/src/config.rs
@@ -751,7 +751,7 @@ pub fn get_config<E: EthSpec>(
 
     if cli_args.is_present("disable-proposer-reorgs") {
         client_config.chain.re_org_head_threshold = None;
-        client_config.chain.re_org_parent_threshold = Some(ReOrgThreshold(u64::MAX));
+        client_config.chain.re_org_parent_threshold = None;
     } else {
         client_config.chain.re_org_head_threshold = Some(
             clap_utils::parse_optional(cli_args, "proposer-reorg-threshold")?

diff --git a/book/src/help_bn.md b/book/src/help_bn.md
@@ -385,8 +385,11 @@ OPTIONS:
         --proposer-reorg-epochs-since-finalization <EPOCHS>
             Maximum number of epochs since finalization at which proposer reorgs are allowed. Default: 2
 
+        --proposer-reorg-parent-threshold <PERCENT>
+            Percentage of parent vote weight above which to attempt a proposer reorg. Default: 160%
+
         --proposer-reorg-threshold <PERCENT>
-            Percentage of vote weight below which to attempt a proposer reorg. Default: 20%
+            Percentage of head vote weight below which to attempt a proposer reorg. Default: 20%
 
         --prune-blobs <BOOLEAN>
             Prune blobs from Lighthouse's database when they are older than the data data availability boundary relative

diff --git a/lighthouse/tests/beacon_node.rs b/lighthouse/tests/beacon_node.rs
@@ -2217,15 +2217,14 @@ fn enable_proposer_re_orgs_default() {
         });
 }
 
-// TODO(is_parent_strong)
 #[test]
 fn disable_proposer_re_orgs() {
     CommandLineTest::new()
         .flag("disable-proposer-reorgs", None)
         .run_with_zero_port()
         .with_config(|config| {
             assert_eq!(config.chain.re_org_head_threshold, None);
-            assert_eq!(config.chain.re_org_parent_threshold.unwrap().0, u64::MAX)
+            assert_eq!(config.chain.re_org_parent_threshold, None)
         });
 }