Skip to content

Commit

Permalink
Fix test failure on Rust v1.81 (#6407)
Browse files Browse the repository at this point in the history
* generate rand f64 instead of arbitrary to prevent NaN vals

* reintroduce quickcheck arbitrary but prevet NaN
  • Loading branch information
eserilev authored Sep 19, 2024
1 parent 8b085dd commit 8a085fc
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions beacon_node/lighthouse_network/src/peer_manager/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2345,6 +2345,16 @@ mod tests {
gossipsub_score: f64,
}

// generate an arbitrary f64 while preventing NaN values
fn arbitrary_f64(g: &mut Gen) -> f64 {
loop {
let val = f64::arbitrary(g);
if !val.is_nan() {
return val;
}
}
}

impl Arbitrary for PeerCondition {
fn arbitrary(g: &mut Gen) -> Self {
let attestation_net_bitfield = {
Expand All @@ -2370,9 +2380,9 @@ mod tests {
outgoing: bool::arbitrary(g),
attestation_net_bitfield,
sync_committee_net_bitfield,
score: f64::arbitrary(g),
score: arbitrary_f64(g),
trusted: bool::arbitrary(g),
gossipsub_score: f64::arbitrary(g),
gossipsub_score: arbitrary_f64(g),
}
}
}
Expand Down

0 comments on commit 8a085fc

Please sign in to comment.