Skip to content

Commit

Permalink
Use make cli-local in CI test suite to remove redundant docker (#6531)
Browse files Browse the repository at this point in the history
* Remove docker command from `make cli`.

* Run `cli-local` on CI.

* Update Makefile

Co-authored-by: Mac L <mjladson@pm.me>
  • Loading branch information
jimmygchen and macladson authored Oct 22, 2024
1 parent b88cb8c commit ad229a6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ jobs:
channel: stable
cache-target: release
- name: Run Makefile to trigger the bash script
run: make cli
run: make cli-local
# This job succeeds ONLY IF all others succeed. It is used by the merge queue to determine whether
# a PR is safe to merge. New jobs should be added here.
test-suite-success:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ test-exec-engine:
# test vectors.
test: test-release

# Updates the CLI help text pages in the Lighthouse book, building with Docker.
# Updates the CLI help text pages in the Lighthouse book, building with Docker (primarily for Windows users).
cli:
docker run --rm --user=root \
-v ${PWD}:/home/runner/actions-runner/lighthouse sigmaprime/github-runner \
Expand Down

0 comments on commit ad229a6

Please sign in to comment.