Skip to content

Commit

Permalink
Update Java runtime requirement to 17 for Web3Signer tests (#4681)
Browse files Browse the repository at this point in the history
Web3Signer now requires Java runtime v17, see [v23.8.0 release](https://github.com/Consensys/web3signer/releases/tag/23.8.0).

We have some Web3Signer tests that requires a compatible Java runtime to be installed on dev machines. This PR updates `setup` documentation in Lighthouse book, and also fixes a small typo.
  • Loading branch information
jimmygchen committed Sep 15, 2023
1 parent e4ed317 commit b88e57c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion book/src/setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ The additional requirements for developers are:
don't have `anvil` available on your `PATH`.
- [`cmake`](https://cmake.org/cmake/help/latest/command/install.html). Used by
some dependencies. See [`Installation Guide`](./installation.md) for more info.
- [`java 11 runtime`](https://openjdk.java.net/projects/jdk/). 11 is the minimum,
- [`java 17 runtime`](https://openjdk.java.net/projects/jdk/). 17 is the minimum,
used by web3signer_tests.
- [`libpq-dev`](https://www.postgresql.org/docs/devel/libpq.html). Also know as
`libpq-devel` on some systems.
Expand Down
2 changes: 1 addition & 1 deletion testing/web3signer_tests/tls/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## TLS Testing Files

The files in this directory are used for testing TLS with web3signer. We store them in this
repository since the are not sensitive and it's simpler than regenerating them for each test.
repository since they are not sensitive and it's simpler than regenerating them for each test.

The files were generated using the `./generate.sh` script.

0 comments on commit b88e57c

Please sign in to comment.