Allow all RPC messages on disconnect (#5876)

Squashed commit of the following:

commit 6d42ebc
Author: Age Manning <Age@AgeManning.com>
Date:   Fri May 31 20:21:26 2024 +1000

    Permit rpc messages on disconnect

beacon_node/lighthouse_network/src/service/mod.rs

@@ -1389,26 +1389,17 @@ impl<AppReqId: ReqId, E: EthSpec> Network<AppReqId, E> {
     ) -> Option<NetworkEvent<AppReqId, E>> {
         let peer_id = event.peer_id;
 
-        if !self.peer_manager().is_connected(&peer_id) {
-            // Sync expects a RPCError::Disconnected to drop associated lookups with this peer.
-            // Silencing this event breaks the API contract with RPC where every request ends with
-            // - A stream termination event, or
-            // - An RPCError event
-            return if let HandlerEvent::Err(HandlerErr::Outbound {
-                id: RequestId::Application(id),
-                error,
-                ..
-            }) = event.event
-            {
-                Some(NetworkEvent::RPCFailed { peer_id, id, error })
-            } else {
-                debug!(
-                    self.log,
-                    "Ignoring rpc message of disconnecting peer";
-                    event
-                );
-                None
-            };
+        if !self.peer_manager().is_connected(&peer_id)
+            // Do not permit Inbound events from peers that are being disconnected
+            && matches!(event.event, HandlerEvent::Err(HandlerErr::Inbound { .. }))
+            && matches!(event.event, HandlerEvent::Ok(RPCReceived::Request(..)))
+        {
+            debug!(
+                self.log,
+                "Ignoring rpc message of disconnecting peer";
+                event
+            );
+            return None;
         }
 
         let handler_id = event.conn_id;