Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mev-boost timeout #4709

Closed
xanatos opened this issue Sep 6, 2023 · 3 comments
Closed

mev-boost timeout #4709

xanatos opened this issue Sep 6, 2023 · 3 comments
Labels
builder API enhancement New feature or request low-hanging-fruit Easy to resolve, get it before someone else does! UX-and-logs v5.2.0 Q2 2024

Comments

@xanatos
Copy link

xanatos commented Sep 6, 2023

I use mev-boost 1.6 and lighthouse v4.3.0-dfcb336 on Windows 11

These weeks I had two blocks that timed out in the call to mev-boost. It seems that lighthouse has a hard timeout of 1sec, and twice mev-boost was a little slower (1.1-1.2sec).

Is it possible to increase this timeout?

(I'll add that the block was still generated internally by lighthouse, without the MEV)

The log files of lighthouse and mev-boost:

Lighthouse: Sep 06 xx:34:11.300 INFO Requesting blinded header from connected builder
Lighthouse: Sep 06 xx:34:12.313 INFO Requested blinded execution payloadlocal_response_ms: 10, ..., relay_response_ms: 1013, relay_fee_recipient: request failed, service: exec
Lighthouse: Sep 06 xx:34:12.313 WARN Builder error when requesting payload relay_error: HttpClient(url: http://localhost:18550/, kind: timeout, detail: operation timed out), info: falling back to local execution client, service: exec
Lighthouse: Sep 06 xx:34:12.557 INFO Reconstructing a full block using a local payload, block_hash: ...

MevBoost: time="2023-09-06Txx:34:11.608+02:00" level=info msg="getHeader request start - 608 milliseconds into slot ..." genesisTime=.... slotTimeSec=12 ua=Lighthouse/v4.3.0-dfcb336 version=v1.6
MevBoost: time="2023-09-06Txx:34:12.446+02:00" level=info msg="best bid" blockHash=... blockNumber=.... method=getHeader ... relays="https://aestus.live/" slot=7265869 ua=Lighthouse/v4.3.0-dfcb336 value=... version=v1.6
MevBoost: time="2023-09-06Txx:34:12.446+02:00" level=info msg="http: GET /eth/v1/builder/header/.../..../... 200" duration=0.838280 method=GET path=/eth/v1/builder/header/.../.../... status=200 version=v1.6

I'll add that I've looked for the duration=... in the mev-boost log, and the last blocks that it relayed had:

duration=0.540568
duration=0.363306
duration=0.504703
duration=0.573797
duration=0.367252
duration=0.499827
duration=0.754806 <- Timeout on lighthouse
duration=0.355462
duration=0.838280 <- Timeout on lighthouse

@xanatos
Copy link
Author

xanatos commented Sep 6, 2023

Annotation: it seems that Nimbus uses 1500ms: status-im/nimbus-eth2#5090
In lighthouse the timeout is set here:

/// This timeout is in accordance with v0.2.0 of the [builder specs](https://github.com/flashbots/mev-boost/pull/20).
pub const DEFAULT_GET_HEADER_TIMEOUT_MILLIS: u64 = 1000;

@michaelsproul michaelsproul added v5.2.0 Q2 2024 low-hanging-fruit Easy to resolve, get it before someone else does! labels May 28, 2024
@michaelsproul
Copy link
Member

we'll add a new CLI flag: --builder-header-timeout-ms

@eserilev
Copy link
Collaborator

Completed in #5857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder API enhancement New feature or request low-hanging-fruit Easy to resolve, get it before someone else does! UX-and-logs v5.2.0 Q2 2024
Projects
None yet
Development

No branches or pull requests

3 participants