Add builder header timeout flag #5857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to force minimum and maximum values for this flag? I don't see why anyone would want this set to less than one second, or to more than 2-3 seconds |
dapplion
reviewed
May 28, 2024
There was a problem hiding this comment.
Do we want to force minimum and maximum values for this flag? I don't see why anyone would want this set to less than one second, or to more than 2-3 seconds
If you set a very low value you will prioritize local building, which you can do today already.
If you set a very high value you will never consider local building and potentially cause liveness issues if builders misbehave. In extreme cases the failover should kick in switching to local building if the failures are common.
I have a soft opinion towards not specifying neither a minimum nor a maximum
jxs
reviewed
May 28, 2024
jimmygchen
added
waiting-on-author
jimmygchen
requested changes
May 29, 2024
michaelsproul
approved these changes
May 30, 2024
michaelsproul
added a commit
that referenced
this pull request
May 30, 2024
Squashed commit of the following: commit 5950106 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Wed May 29 22:43:11 2024 +0200 update cli commit 773c4d4 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Wed May 29 20:04:02 2024 +0200 add upper limit check, changes based on feedback commit 8d1f865 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Tue May 28 18:43:13 2024 +0200 make cli commit 30f9dec Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Tue May 28 18:29:22 2024 +0200 add a new flag that allows for configuring the timeout for get builder header api calls commit e87cf1d Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Tue May 28 15:52:10 2024 +0200 fix bitvector test random impl
Merged
eserilev
added
ready-for-review
michaelsproul
added
ready-for-merge
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at fbc230e |
5 tasks
michaelsproul
added a commit
that referenced
this pull request
May 31, 2024
Squashed commit of the following: commit 5950106 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Wed May 29 22:43:11 2024 +0200 update cli commit 773c4d4 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Wed May 29 20:04:02 2024 +0200 add upper limit check, changes based on feedback commit 8d1f865 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Tue May 28 18:43:13 2024 +0200 make cli commit 30f9dec Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Tue May 28 18:29:22 2024 +0200 add a new flag that allows for configuring the timeout for get builder header api calls commit e87cf1d Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Tue May 28 15:52:10 2024 +0200 fix bitvector test random impl
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#4709
Proposed Changes
Add a new flag
builder-header-timeoutwhich allows for configuring timeouts for the get builder header api call. Ive added a max limit of 3 seconds to the timeout to prevent potential liveness issues.